[Gd-chatter] r11128 - trunk/libraries/network/koala/sources/koala

[cgay at gwydiondylan.org]

Author: cgay
Date: Fri Jan 12 04:27:58 2007
New Revision: 11128

Modified:
   trunk/libraries/network/koala/sources/koala/log.dylan
Log:
job: minor
Changed comments only.


Modified: trunk/libraries/network/koala/sources/koala/log.dylan
==============================================================================
--- trunk/libraries/network/koala/sources/koala/log.dylan	(original)
+++ trunk/libraries/network/koala/sources/koala/log.dylan	Fri Jan 12 04:27:58 2007
@@ -9,15 +9,25 @@
 /*
 How koala logging works:
 
-Each virtual host has (potentially) three different log targets:
-errors, activity, debug output.  (These target could all be the
-same.)  Each virtual host has its own applicable log level.  The
-most basic method for doing logging is log-message, which is
-passed a <log-target> and a <log-level>.  If the log-level passed
-to log-message is an instance of the active log level for the
-current virtual host the the message will be logged. Otherwise
-it'll be dropped on the floor.  <log-target>s allow for arbitrary
-backing store for logs, like files, databases, the net, etc.
+Each virtual host has (potentially) three different log targets: errors,
+activity, and debug output.  (These targets could all be the same.)  Each
+virtual host has its own applicable log level.  The most basic method for doing
+logging is log-message, which is passed a <log-target> and a <log-level>.  If
+the log-level passed to log-message is an instance of the active log level for
+the current virtual host then the message will be logged. Otherwise it'll be
+dropped on the floor.  <log-target>s allow for arbitrary backing store for
+logs, like files, databases, the net, etc.
+
+
+todo -- Thread safety?
+
+todo -- Handle errors gracefully.  e.g., if the disk fills up it may be
+        better to do nothing than to crash the web server.
+
+todo -- If this were separated out into a real logging library I'd want
+        it to support multiple log targets, a log "context" (e.g., the current
+        thread name), and more flexible formatting.
+
 */
 
 // Root of the log level hierarchy.  Logging uses a simple class
@@ -94,7 +104,7 @@
     (level :: <log-level>, target :: <log-target>, format-string :: <string>,
      #rest format-args)
   if (log-level-applicable?(level, target))
-    // TODO: Using concatenate would be more efficient that with-output-to-string.
+    // TODO: Using concatenate would be more efficient than with-output-to-string.
     let line :: <string>
       = with-output-to-string (stream)
           date-to-stream(stream, current-date());