[chatter] r11778 - in trunk/fundev/sources: dylan/tests functional-dylan/tests system/locators system/tests

[cgay at mccarthy.opendylan.org]

Author: cgay
Date: Sun Apr 27 13:13:03 2008
New Revision: 11778

Modified:
   trunk/fundev/sources/dylan/tests/control.dylan
   trunk/fundev/sources/functional-dylan/tests/functions.dylan
   trunk/fundev/sources/system/locators/web-locators.dylan
   trunk/fundev/sources/system/tests/date.dylan
   trunk/fundev/sources/system/tests/temp-files.dylan
Log:
job: fd
Fixed some compiler warnings in the dylan-test-suite.  Please
carefully review the change from check-equal to check-condition.  I
convinced myself this is correct after reading the Parameter Lists
section in the DRM again, but it's a bit complicated.

A few other minor changes as well.

Modified: trunk/fundev/sources/dylan/tests/control.dylan
==============================================================================
--- trunk/fundev/sources/dylan/tests/control.dylan	(original)
+++ trunk/fundev/sources/dylan/tests/control.dylan	Sun Apr 27 13:13:03 2008
@@ -488,11 +488,11 @@
   check-equal("one param call one arg",
 	     (method (x) x end)(1), 1);
   check-condition("no param call one arg", <error>,
-   		  no-param-function(1));
+                  apply(no-param-function, #[1]));
   check-condition("one param call no args", <error>,
-		  one-param-function());
+                  apply(one-param-function, #[]));
   check-condition("one param call two args", <error>,
-		  one-param-function(1, 2));
+                  apply(one-param-function, #[1, 2]));
   check-equal("two args call",
 	     (method (x, y) x + y end)(1, 2), 3);
   check-equal("lots args call",
@@ -537,8 +537,8 @@
 	      (method (#rest keys, #key) keys end)(), #[]);
   check-equal("rest one key call no args", 
 	      (method (#rest keys, #key x) keys end)(), #[]);
-  check-equal("rest one key call one arg", 
-	      (method (#rest keys, #key) keys end)(x: 1), #[#"x", 1]);
+  check-condition("rest one key call one arg", <error>,
+                  (method (#rest keys, #key) keys end)(x: 1));
   check-equal("rest one key call one arg keys", 
 	      (method (#rest keys, #key x) keys end)(x: 1), #[#"x", 1]);
   check-equal("rest one key call one arg key", 

Modified: trunk/fundev/sources/functional-dylan/tests/functions.dylan
==============================================================================
--- trunk/fundev/sources/functional-dylan/tests/functions.dylan	(original)
+++ trunk/fundev/sources/functional-dylan/tests/functions.dylan	Sun Apr 27 13:13:03 2008
@@ -212,7 +212,7 @@
 define functional-extensions function-test split ()
   check-equal("split on empty string",
               split("", '/'),
-              #[]);
+              #[""]);
   check-equal("split on single character",
 	      split("a", '/'),
 	      #["a"]);
@@ -248,10 +248,10 @@
 	      #["major", "", "build"]);
   check-equal("split with spaces",
 	      split("major, minor, build", ','),
-	      #["major", "minor", "build"]);
+	      #["major", " minor", " build"]);
   check-equal("split with spaces everywhere",
 	      split(" major , minor , build ", ','),
-	      #["major", "minor", "build"]);
+	      #[" major ", " minor ", " build "]);
   check-equal("no trim split with spaces",
 	      split("major, minor, build", ',', trim?: #f),
 	      #["major", " minor", " build"]);

Modified: trunk/fundev/sources/system/locators/web-locators.dylan
==============================================================================
--- trunk/fundev/sources/system/locators/web-locators.dylan	(original)
+++ trunk/fundev/sources/system/locators/web-locators.dylan	Sun Apr 27 13:13:03 2008
@@ -436,6 +436,9 @@
 
 /// File index locators
 
+// These might be better called <fragment-locator> to follow the terminology in
+// RFC 3986.
+
 define sealed class <file-index-url> (<url>)
   sealed constant slot locator-file :: <file-url>,
     required-init-keyword: file:;
@@ -463,6 +466,9 @@
 
 /// CGI locators
 
+// These might be better called <query-locator> to follow the terminology in
+// RFC 3986.
+
 define sealed class <cgi-url> (<url>)
   sealed constant slot locator-file :: <file-url>,
     required-init-keyword: file:;

Modified: trunk/fundev/sources/system/tests/date.dylan
==============================================================================
--- trunk/fundev/sources/system/tests/date.dylan	(original)
+++ trunk/fundev/sources/system/tests/date.dylan	Sun Apr 27 13:13:03 2008
@@ -223,7 +223,7 @@
 		(make(<date>, year: 2000, month: 1, day: 1, hours: 0,
 		      minutes: 0, seconds: 0, time-zone-offset: 0,
 		      microseconds: 0)),
-	      "20000101T000000Z");
+	      "2000-01-01T00:00:00+00:00");
   
 				     
 end;

Modified: trunk/fundev/sources/system/tests/temp-files.dylan
==============================================================================
--- trunk/fundev/sources/system/tests/temp-files.dylan	(original)
+++ trunk/fundev/sources/system/tests/temp-files.dylan	Sun Apr 27 13:13:03 2008
@@ -38,7 +38,7 @@
     counter := *temp-file-counter*;
   end;
   let filename = concatenate(initial-substring | "",
-			     copy-sequence(as-iso8601-string(now), start: 6),
+			     format-date("%d%H%M%S.", now),
 			     integer-to-string(counter, size: 6),
 			     (extension & ".") | "",
 			     extension | "");